• Jiri Slaby's avatar
    MFD: rtsx_pcr: Fix probe fail path · 9d66b568
    Jiri Slaby authored
    When rtsx_pci_acquire_irq fails in rtsx_pci_probe, we forget to
    disable an MSI (if we enabled it). This results in this warning on the
    next attempt to load the module:
    WARNING: at drivers/pci/msi.c:834 pci_enable_msi_block+0x2a4/0x2b0()
    Hardware name: HP EliteBook 840 G1
    Modules linked in: rtsx_pci(+) ...
    Pid: 4056, comm: modprobe Tainted: G          I  3.8.0-9405-gd895cb1a-1-vanilla #1
    Call Trace:
     [<ffffffff81045c6a>] warn_slowpath_common+0x7a/0xc0
     [<ffffffff81045cc5>] warn_slowpath_null+0x15/0x20
     [<ffffffff81302544>] pci_enable_msi_block+0x2a4/0x2b0
     [<ffffffffa05e335a>] rtsx_pci_probe+0x55a/0x720 [rtsx_pci]
    ...
    
    So properly disable MSI in that case.
    Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
    Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
    9d66b568
rtsx_pcr.c 30 KB