• Yonghong Song's avatar
    bpf: fix compiler warning with CONFIG_MODULES=n · 9db1ff0a
    Yonghong Song authored
    With CONFIG_MODULES=n, the following compiler warning occurs:
      /data/users/yhs/work/net-next/kernel/trace/bpf_trace.c:605:13: warning:
          ‘do_bpf_send_signal’ defined but not used [-Wunused-function]
      static void do_bpf_send_signal(struct irq_work *entry)
    
    The __init function send_signal_irq_work_init(), which calls
    do_bpf_send_signal(), is defined under CONFIG_MODULES. Hence,
    when CONFIG_MODULES=n, nobody calls static function do_bpf_send_signal(),
    hence the warning.
    
    The init function send_signal_irq_work_init() should work without
    CONFIG_MODULES. Moving it out of CONFIG_MODULES
    code section fixed the compiler warning, and also make bpf_send_signal()
    helper work without CONFIG_MODULES.
    
    Fixes: 8b401f9e ("bpf: implement bpf_send_signal() helper")
    Reported-By: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarYonghong Song <yhs@fb.com>
    Acked-by: default avatarSong Liu <songliubraving@fb.com>
    Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
    9db1ff0a
bpf_trace.c 39.5 KB