• Marc Zyngier's avatar
    irqchip/gic-v3: Workaround inconsistent PMR setting on NMI entry · 382e6e17
    Marc Zyngier authored
    The arm64 entry code suffers from an annoying issue on taking
    a NMI, as it sets PMR to a value that actually allows IRQs
    to be acknowledged. This is done for consistency with other parts
    of the code, and is in the process of being fixed. This shouldn't
    be a problem, as we are not enabling interrupts whilst in NMI
    context.
    
    However, in the infortunate scenario that we took a spurious NMI
    (retired before the read of IAR) *and* that there is an IRQ pending
    at the same time, we'll ack the IRQ in NMI context. Too bad.
    
    In order to avoid deadlocks while running something like perf,
    teach the GICv3 driver about this situation: if we were in
    a context where no interrupt should have fired, transiently
    set PMR to a value that only allows NMIs before acking the pending
    interrupt, and restore the original value after that.
    
    This papers over the core issue for the time being, and makes
    NMIs great again. Sort of.
    
    Fixes: 4d6a38da ("arm64: entry: always set GIC_PRIO_PSR_I_SET during entry")
    Co-developed-by: default avatarMark Rutland <mark.rutland@arm.com>
    Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
    Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
    Reviewed-by: default avatarMark Rutland <mark.rutland@arm.com>
    Link: https://lore.kernel.org/lkml/20210610145731.1350460-1-maz@kernel.org
    382e6e17
irq-gic-v3.c 55.9 KB