• Kees Cook's avatar
    bcachefs: Refactor memcpy into direct assignment · 7413ab70
    Kees Cook authored
    The memcpy() in bch2_bkey_append_ptr() is operating on an embedded fake
    flexible array which looks to the compiler like it has 0 size. This
    causes W=1 builds to emit warnings due to -Wstringop-overflow:
    
       In file included from include/linux/string.h:254,
                        from include/linux/bitmap.h:11,
                        from include/linux/cpumask.h:12,
                        from include/linux/smp.h:13,
                        from include/linux/lockdep.h:14,
                        from include/linux/radix-tree.h:14,
                        from include/linux/backing-dev-defs.h:6,
                        from fs/bcachefs/bcachefs.h:182:
       fs/bcachefs/extents.c: In function 'bch2_bkey_append_ptr':
       include/linux/fortify-string.h:57:33: warning: writing 8 bytes into a region of size 0 [-Wstringop-overflow=]
          57 | #define __underlying_memcpy     __builtin_memcpy
             |                                 ^
       include/linux/fortify-string.h:648:9: note: in expansion of macro '__underlying_memcpy'
         648 |         __underlying_##op(p, q, __fortify_size);                        \
             |         ^~~~~~~~~~~~~
       include/linux/fortify-string.h:693:26: note: in expansion of macro '__fortify_memcpy_chk'
         693 | #define memcpy(p, q, s)  __fortify_memcpy_chk(p, q, s,                  \
             |                          ^~~~~~~~~~~~~~~~~~~~
       fs/bcachefs/extents.c:235:17: note: in expansion of macro 'memcpy'
         235 |                 memcpy((void *) &k->v + bkey_val_bytes(&k->k),
             |                 ^~~~~~
       fs/bcachefs/bcachefs_format.h:287:33: note: destination object 'v' of size 0
         287 |                 struct bch_val  v;
             |                                 ^
    
    Avoid making any structure changes and just replace the u64 copy into a
    direct assignment, side-stepping the entire problem.
    
    Cc: Kent Overstreet <kent.overstreet@linux.dev>
    Cc: Brian Foster <bfoster@redhat.com>
    Cc: linux-bcachefs@vger.kernel.org
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Closes: https://lore.kernel.org/oe-kbuild-all/202309192314.VBsjiIm5-lkp@intel.com/
    Link: https://lore.kernel.org/r/20231010235609.work.594-kees@kernel.orgSigned-off-by: default avatarKees Cook <keescook@chromium.org>
    Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
    7413ab70
extents.h 20.5 KB