• Hui Wang's avatar
    ASoC: cs35l41: Fix an out-of-bounds access in otp_packed_element_t · 9f342904
    Hui Wang authored
    The CS35L41_NUM_OTP_ELEM is 100, but only 99 entries are defined in
    the array otp_map_1/2[CS35L41_NUM_OTP_ELEM], this will trigger UBSAN
    to report a shift-out-of-bounds warning in the cs35l41_otp_unpack()
    since the last entry in the array will result in GENMASK(-1, 0).
    
    UBSAN reports this problem:
     UBSAN: shift-out-of-bounds in /home/hwang4/build/jammy/jammy/sound/soc/codecs/cs35l41-lib.c:836:8
     shift exponent 64 is too large for 64-bit type 'long unsigned int'
     CPU: 10 PID: 595 Comm: systemd-udevd Not tainted 5.15.0-23-generic #23
     Hardware name: LENOVO \x02MFG_IN_GO/\x02MFG_IN_GO, BIOS N3GET19W (1.00 ) 03/11/2022
     Call Trace:
      <TASK>
      show_stack+0x52/0x58
      dump_stack_lvl+0x4a/0x5f
      dump_stack+0x10/0x12
      ubsan_epilogue+0x9/0x45
      __ubsan_handle_shift_out_of_bounds.cold+0x61/0xef
      ? regmap_unlock_mutex+0xe/0x10
      cs35l41_otp_unpack.cold+0x1c6/0x2b2 [snd_soc_cs35l41_lib]
      cs35l41_hda_probe+0x24f/0x33a [snd_hda_scodec_cs35l41]
      cs35l41_hda_i2c_probe+0x65/0x90 [snd_hda_scodec_cs35l41_i2c]
      ? cs35l41_hda_i2c_remove+0x20/0x20 [snd_hda_scodec_cs35l41_i2c]
      i2c_device_probe+0x252/0x2b0
    
    Fixes: 6450ef55 ("ASoC: cs35l41: CS35L41 Boosted Smart Amplifier")
    Reviewed-by: default avatarLucas Tanure <tanureal@opensource.cirrus.com>
    Acked-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
    Signed-off-by: default avatarHui Wang <hui.wang@canonical.com>
    Link: https://lore.kernel.org/r/20220328123535.50000-2-hui.wang@canonical.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    9f342904
cs35l41.h 30.2 KB