• Arnd Bergmann's avatar
    ext4: fix debug format string warning · fcdf3c34
    Arnd Bergmann authored
    Using no_printk() for jbd_debug() revealed two warnings:
    
    fs/jbd2/recovery.c: In function 'fc_do_one_pass':
    fs/jbd2/recovery.c:256:30: error: format '%d' expects a matching 'int' argument [-Werror=format=]
      256 |                 jbd_debug(3, "Processing fast commit blk with seq %d");
          |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    fs/ext4/fast_commit.c: In function 'ext4_fc_replay_add_range':
    fs/ext4/fast_commit.c:1732:30: error: format '%d' expects argument of type 'int', but argument 2 has type 'long unsigned int' [-Werror=format=]
     1732 |                 jbd_debug(1, "Converting from %d to %d %lld",
    
    The first one was added incorrectly, and was also missing a few newlines
    in debug output, and the second one happened when the type of an
    argument changed.
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Fixes: d5564351 ("jbd2: avoid -Wempty-body warnings")
    Fixes: 6db07461 ("ext4: use BIT() macro for BH_** state bits")
    Fixes: 5b849b5f ("jbd2: fast commit recovery path")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Link: https://lore.kernel.org/r/20210409201211.1866633-1-arnd@kernel.orgSigned-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
    fcdf3c34
recovery.c 23.5 KB