• Alexey Brodkin's avatar
    ARC: Hardcode ARCH_DMA_MINALIGN to max line length we may have · 9f82e90a
    Alexey Brodkin authored
    Current implementation relies on L1 line length which might easily
    be smaller than L2 line (which is usually the case BTW).
    
    Imagine this typical case: L2 line is 128 bytes while L1 line is
    64-bytes. Now we want to allocate small buffer and later use it for DMA
    (consider IOC is not available).
    
    kmalloc() allocates small KMALLOC_MIN_SIZE-sized, KMALLOC_MIN_SIZE-aligned
    That way if buffer happens to be aligned to L1 line and not L2 line we'll be
    flushing and invalidating extra portions of data from L2 which will cause
    cache coherency issues.
    
    And since KMALLOC_MIN_SIZE is bound to ARCH_DMA_MINALIGN the fix could
    be simple - set ARCH_DMA_MINALIGN to the largest cache line we may ever
    get. As of today neither L1 of ARC700 and ARC HS38 nor SLC might not be
    longer than 128 bytes.
    Signed-off-by: default avatarAlexey Brodkin <abrodkin@synopsys.com>
    Signed-off-by: default avatarVineet Gupta <vgupta@synopsys.com>
    9f82e90a
cache.h 3.15 KB