• Wei Wang's avatar
    KVM: x86: remove PMU FIXED_CTR3 from msrs_to_save_all · 9fb12fe5
    Wei Wang authored
    The fixed counter 3 is used for the Topdown metrics, which hasn't been
    enabled for KVM guests. Userspace accessing to it will fail as it's not
    included in get_fixed_pmc(). This breaks KVM selftests on ICX+ machines,
    which have this counter.
    
    To reproduce it on ICX+ machines, ./state_test reports:
    ==== Test Assertion Failure ====
    lib/x86_64/processor.c:1078: r == nmsrs
    pid=4564 tid=4564 - Argument list too long
    1  0x000000000040b1b9: vcpu_save_state at processor.c:1077
    2  0x0000000000402478: main at state_test.c:209 (discriminator 6)
    3  0x00007fbe21ed5f92: ?? ??:0
    4  0x000000000040264d: _start at ??:?
     Unexpected result from KVM_GET_MSRS, r: 17 (failed MSR was 0x30c)
    
    With this patch, it works well.
    Signed-off-by: default avatarWei Wang <wei.w.wang@intel.com>
    Message-Id: <20211217124934.32893-1-wei.w.wang@intel.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    9fb12fe5
x86.c 331 KB