• NeilBrown's avatar
    NFS: avoid spurious warning of lost lock that is being unlocked. · ef8d98f2
    NeilBrown authored
    When the NFSv4 state manager recovers state after a server restart, it
    reports that locks have been lost if it finds any lock state for which
    recovery hasn't been successful.  i.e. any for which
    NFS_LOCK_INITIALIZED is not set.
    
    However it only tries to recover locks that are still linked to
    inode->i_flctx.  So if a lock has been removed from inode->i_flctx, but
    the state for that lock has not yet been destroyed, then a spurious
    warning results.
    
    nfs4_proc_unlck() calls locks_lock_inode_wait() - which removes the lock
    from ->i_flctx - before sending the unlock request to the server and
    before the final nfs4_put_lock_state() is called.  This allows a window
    in which a spurious warning can be produced.
    
    So add a new flag NFS_LOCK_UNLOCKING which is set once the decision has
    been made to unlock the lock.  This will prevent it from triggering any
    warning.
    Signed-off-by: default avatarNeilBrown <neilb@suse.de>
    Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
    ef8d98f2
nfs4_fs.h 22.9 KB