• zhengliang's avatar
    f2fs: fix to data block override node segment by mistake · a0770e13
    zhengliang authored
    v4: Rearrange the previous three versions.
    
    The following scenario could lead to data block override by mistake.
    
    TASK A            |  TASK kworker                                            |     TASK B                                            |       TASK C
                      |                                                          |                                                       |
    open              |                                                          |                                                       |
    write             |                                                          |                                                       |
    close             |                                                          |                                                       |
                      |  f2fs_write_data_pages                                   |                                                       |
                      |    f2fs_write_cache_pages                                |                                                       |
                      |      f2fs_outplace_write_data                            |                                                       |
                      |        f2fs_allocate_data_block (get block in seg S,     |                                                       |
                      |                                  S is full, and only     |                                                       |
                      |                                  have this valid data    |                                                       |
                      |                                  block)                  |                                                       |
                      |          allocate_segment                                |                                                       |
                      |          locate_dirty_segment (mark S as PRE)            |                                                       |
                      |        f2fs_submit_page_write (submit but is not         |                                                       |
                      |                                written on dev)           |                                                       |
    unlink            |                                                          |                                                       |
     iput_final       |                                                          |                                                       |
      f2fs_drop_inode |                                                          |                                                       |
        f2fs_truncate |                                                          |                                                       |
     (not evict)      |                                                          |                                                       |
                      |                                                          | write_checkpoint                                      |
                      |                                                          |  flush merged bio but not wait file data writeback    |
                      |                                                          |  set_prefree_as_free (mark S as FREE)                 |
                      |                                                          |                                                       | update NODE/DATA
                      |                                                          |                                                       | allocate_segment (select S)
                      |     writeback done                                       |                                                       |
    
    So we need to guarantee io complete before truncate inode in f2fs_drop_inode.
    Reviewed-by: default avatarChao Yu <yuchao0@huawei.com>
    Signed-off-by: default avatarZheng Liang <zhengliang6@huawei.com>
    Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
    a0770e13
super.c 91.7 KB