• Johan Hovold's avatar
    Bluetooth: qca: fix NVM configuration parsing · a112d3c7
    Johan Hovold authored
    The NVM configuration files used by WCN3988 and WCN3990/1/8 have two
    sets of configuration tags that are enclosed by a type-length header of
    type four which the current parser fails to account for.
    
    Instead the driver happily parses random data as if it were valid tags,
    something which can lead to the configuration data being corrupted if it
    ever encounters the words 0x0011 or 0x001b.
    
    As is clear from commit b6388254 ("Bluetooth: btqca: Fix the NVM
    baudrate tag offcet for wcn3991") the intention has always been to
    process the configuration data also for WCN3991 and WCN3998 which
    encodes the baud rate at a different offset.
    
    Fix the parser so that it can handle the WCN3xxx configuration files,
    which has an enclosing type-length header of type four and two sets of
    TLV tags enclosed by a type-length header of type two and three,
    respectively.
    
    Note that only the first set, which contains the tags the driver is
    currently looking for, will be parsed for now.
    
    With the parser fixed, the software in-band sleep bit will now be set
    for WCN3991 and WCN3998 (as it is for later controllers) and the default
    baud rate 3200000 may be updated by the driver also for WCN3xxx
    controllers.
    
    Notably the deep-sleep feature bit is already set by default in all
    configuration files in linux-firmware.
    
    Fixes: 4219d468 ("Bluetooth: btqca: Add wcn3990 firmware download support.")
    Cc: stable@vger.kernel.org	# 4.19
    Cc: Matthias Kaehlcke <mka@chromium.org>
    Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
    Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
    a112d3c7
btqca.c 22.5 KB