• Tvrtko Ursulin's avatar
    drm/i915/guc: Fix sleep under spinlock during reset · a3662830
    Tvrtko Ursulin authored
    Looks like intel_guc_reset had the ability to sleep under the
    uncore spinlock since forever but it wasn't detected until the
    recent changes annotated the wait for register with might_sleep.
    
    I have fixed it by removing holding of the uncore spinlock over
    the call to gen6_hw_domain_reset, since I do not see that is
    really needed. But there is always a possibility I am missing
    some nasty detail so please double check.
    Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
    Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
    Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Cc: Oscar Mateo <oscar.mateo@intel.com>
    Acked-by: default avatarMichel Thierry <michel.thierry@intel.com>
    Reviewed-by: default avatarJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
    a3662830
intel_uncore.c 53.4 KB