• Christoph Hellwig's avatar
    [PATCH] Re: scsi_scan.c complaints... · b7ccbd3e
    Christoph Hellwig authored
    On Fri, Dec 20, 2002 at 08:29:23PM -0500, Doug Ledford wrote:
    > And I was right.  One little q = NULL; is all that was missing.  Anyway,
    > here's a printout of what startup looks like with this patch in place
    > under 2.5.52.  This should make you happy Justin ;-)
    
    Okay, I looked at the patches that are in mainline and they look pretty
    cool to me.  When looking over the code (in preparation of implementing
    Justin's suggestion to get rid of the highmem_io flag) I found quite
    a bit small stuff to make the code in that area a lot cleaner:
    
    - new helper scsi_calculate_bounce_limit to calculate the bounce
      limit for a scsi host, remove a copy of that code ni st.c
    - scsi_initialize_queue gets replace with scsi_alloc_queue, this
      one now takes only a struct Scsi_Host and returns the request queue,
      it's paired with a small scsi_free_queue helper.
    
    Diffstat:
    
     hosts.h     |    3 -
     scsi.c      |   43 ----------------------
     scsi.h      |    1
     scsi_scan.c |  113 ++++++++++++++++++++++++++++++++++--------------------------
     scsi_syms.c |    5 ++
     st.c        |   16 +-------
     6 files changed, 73 insertions(+), 108 deletions(-)
    b7ccbd3e
st.c 113 KB