• Ahmed Zaki's avatar
    iavf: use internal state to free traffic IRQs · a77ed5c5
    Ahmed Zaki authored
    If the system tries to close the netdev while iavf_reset_task() is
    running, __LINK_STATE_START will be cleared and netif_running() will
    return false in iavf_reinit_interrupt_scheme(). This will result in
    iavf_free_traffic_irqs() not being called and a leak as follows:
    
        [7632.489326] remove_proc_entry: removing non-empty directory 'irq/999', leaking at least 'iavf-enp24s0f0v0-TxRx-0'
        [7632.490214] WARNING: CPU: 0 PID: 10 at fs/proc/generic.c:718 remove_proc_entry+0x19b/0x1b0
    
    is shown when pci_disable_msix() is later called. Fix by using the
    internal adapter state. The traffic IRQs will always exist if
    state == __IAVF_RUNNING.
    
    Fixes: 5b36e8d0 ("i40evf: Enable VF to request an alternate queue allocation")
    Signed-off-by: default avatarAhmed Zaki <ahmed.zaki@intel.com>
    Tested-by: default avatarRafal Romanowski <rafal.romanowski@intel.com>
    Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
    a77ed5c5
iavf_main.c 144 KB