• Scott Shumate's avatar
    HID: sony: Fix for broken buttons on DS3 USB dongles · e72455b8
    Scott Shumate authored
    Fix for non-working buttons on knock-off USB dongles for Sony
    controllers. These USB dongles are used to connect older Sony DA/DS1/DS2
    controllers via USB and are common on Amazon, AliExpress, etc.  Without
    the patch, the square, X, and circle buttons do not function.  These
    dongles used to work prior to kernel 4.10 but removing the global DS3
    report fixup in commit e19a267b ("HID: sony: DS3 comply to Linux gamepad
    spec") exposed the problem.
    
    Many people reported the problem on the Ubuntu forums and are working
    around the problem by falling back to the 4.9 hid-sony driver.
    
    The problem stems from these dongles incorrectly reporting their button
    count as 13 instead of 16.  This patch fixes up the report descriptor by
    changing the button report count to 16 and removing 3 padding bits.
    
    Cc: stable@vger.kernel.org
    Fixes: e19a267b ("HID: sony: DS3 comply to Linux gamepad spec")
    Signed-off-by: default avatarScott Shumate <scott.shumate@gmail.com>
    Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
    e72455b8
hid-sony.c 91.2 KB