• Thomas Gleixner's avatar
    timers: Prevent base clock corruption when forwarding · 6bad6bcc
    Thomas Gleixner authored
    When a timer is enqueued we try to forward the timer base clock. This
    mechanism has two issues:
    
    1) Forwarding a remote base unlocked
    
    The forwarding function is called from get_target_base() with the current
    timer base lock held. But if the new target base is a different base than
    the current base (can happen with NOHZ, sigh!) then the forwarding is done
    on an unlocked base. This can lead to corruption of base->clk.
    
    Solution is simple: Invoke the forwarding after the target base is locked.
    
    2) Possible corruption due to jiffies advancing
    
    This is similar to the issue in get_net_timer_interrupt() which was fixed
    in the previous patch. jiffies can advance between check and assignement
    and therefore advancing base->clk beyond the next expiry value.
    
    So we need to read jiffies into a local variable once and do the checks and
    assignment with the local copy.
    
    Fixes: a683f390("timers: Forward the wheel clock whenever possible")
    Reported-by: default avatarAshton Holmes <scoopta@gmail.com>
    Reported-by: default avatarMichael Thayer <michael.thayer@oracle.com>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Cc: Michal Necasek <michal.necasek@oracle.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: knut.osmundsen@oracle.com
    Cc: stable@vger.kernel.org
    Cc: stern@rowland.harvard.edu
    Cc: rt@linutronix.de
    Link: http://lkml.kernel.org/r/20161022110552.253640125@linutronix.deSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    6bad6bcc
timer.c 54.7 KB