• Hugh Dickins's avatar
    dma-debug: fix debug_dma_assert_idle(), use rcu_read_lock() · a85ffd59
    Hugh Dickins authored
    Since commit 2a9127fc ("mm: rewrite wait_on_page_bit_common()
    logic") improved unlock_page(), it has become more noticeable how
    cow_user_page() in a kernel with CONFIG_DMA_API_DEBUG=y can create and
    suffer from heavy contention on DMA debug's radix_lock in
    debug_dma_assert_idle().
    
    It is only doing a lookup: use rcu_read_lock() and rcu_read_unlock()
    instead; though that does require the static ents[] to be moved
    onstack...
    
    ...but, hold on, isn't that radix_tree_gang_lookup() and loop doing
    quite the wrong thing: searching CACHELINES_PER_PAGE entries for an
    exact match with the first cacheline of the page in question?
    radix_tree_gang_lookup() is the right tool for the job, but we need
    nothing more than to check the first entry it can find, reporting if
    that falls anywhere within the page.
    
    (Is RCU safe here? As safe as using the spinlock was. The entries are
    never freed, so don't need to be freed by RCU. They may be reused, and
    there is a faint chance of a race, with an offending entry reused while
    printing its error info; but the spinlock did not prevent that either,
    and I agree that it's not worth worrying about. ]
    
    [ Side noe: this patch is a clear improvement to the status quo, but the
      next patch will be removing this debug function entirely.
    
      But just in case we decide we want to resurrect the debugging code
      some day, I'm first applying this improvement patch so that it doesn't
      get lost    - Linus ]
    
    Fixes: 3b7a6418 ("dma debug: account for cachelines and read-only mappings in overlap tracking")
    Signed-off-by: default avatarHugh Dickins <hughd@google.com>
    Acked-by: default avatarDan Williams <dan.j.williams@intel.com>
    Acked-by: default avatarChristoph Hellwig <hch@lst.de>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    a85ffd59
debug.c 42.9 KB