• Jens Axboe's avatar
    io_uring: ensure io_lockdep_assert_cq_locked() handles disabled rings · 1658633c
    Jens Axboe authored
    io_lockdep_assert_cq_locked() checks that locking is correctly done when
    a CQE is posted. If the ring is setup in a disabled state with
    IORING_SETUP_R_DISABLED, then ctx->submitter_task isn't assigned until
    the ring is later enabled. We generally don't post CQEs in this state,
    as no SQEs can be submitted. However it is possible to generate a CQE
    if tagged resources are being updated. If this happens and PROVE_LOCKING
    is enabled, then the locking check helper will dereference
    ctx->submitter_task, which hasn't been set yet.
    
    Fixup io_lockdep_assert_cq_locked() to handle this case correctly. While
    at it, convert it to a static inline as well, so that generated line
    offsets will actually reflect which condition failed, rather than just
    the line offset for io_lockdep_assert_cq_locked() itself.
    
    Reported-and-tested-by: syzbot+efc45d4e7ba6ab4ef1eb@syzkaller.appspotmail.com
    Fixes: f26cc959 ("io_uring: lockdep annotate CQ locking")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    1658633c
io_uring.h 11.2 KB