• Maciej Żenczykowski's avatar
    revert "net: align SO_RCVMARK required privileges with SO_MARK" · a9628e88
    Maciej Żenczykowski authored
    This reverts commit 1f86123b ("net: align SO_RCVMARK required
    privileges with SO_MARK") because the reasoning in the commit message
    is not really correct:
      SO_RCVMARK is used for 'reading' incoming skb mark (via cmsg), as such
      it is more equivalent to 'getsockopt(SO_MARK)' which has no priv check
      and retrieves the socket mark, rather than 'setsockopt(SO_MARK) which
      sets the socket mark and does require privs.
    
      Additionally incoming skb->mark may already be visible if
      sysctl_fwmark_reflect and/or sysctl_tcp_fwmark_accept are enabled.
    
      Furthermore, it is easier to block the getsockopt via bpf
      (either cgroup setsockopt hook, or via syscall filters)
      then to unblock it if it requires CAP_NET_RAW/ADMIN.
    
    On Android the socket mark is (among other things) used to store
    the network identifier a socket is bound to.  Setting it is privileged,
    but retrieving it is not.  We'd like unprivileged userspace to be able
    to read the network id of incoming packets (where mark is set via
    iptables [to be moved to bpf])...
    
    An alternative would be to add another sysctl to control whether
    setting SO_RCVMARK is privilged or not.
    (or even a MASK of which bits in the mark can be exposed)
    But this seems like over-engineering...
    
    Note: This is a non-trivial revert, due to later merged commit e42c7bee
    ("bpf: net: Consider has_current_bpf_ctx() when testing capable() in sk_setsockopt()")
    which changed both 'ns_capable' into 'sockopt_ns_capable' calls.
    
    Fixes: 1f86123b ("net: align SO_RCVMARK required privileges with SO_MARK")
    Cc: Larysa Zaremba <larysa.zaremba@intel.com>
    Cc: Simon Horman <simon.horman@corigine.com>
    Cc: Paolo Abeni <pabeni@redhat.com>
    Cc: Eyal Birger <eyal.birger@gmail.com>
    Cc: Jakub Kicinski <kuba@kernel.org>
    Cc: Eric Dumazet <edumazet@google.com>
    Cc: Patrick Rohr <prohr@google.com>
    Signed-off-by: default avatarMaciej Żenczykowski <maze@google.com>
    Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
    Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
    Link: https://lore.kernel.org/r/20230618103130.51628-1-maze@google.comSigned-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
    a9628e88
sock.c 97.7 KB