• Arnd Bergmann's avatar
    8250: of: remove remnants of generic of_serial driver · aa42db44
    Arnd Bergmann authored
    During build testing, I ran into a warning in a driver that I
    had written myself at some point:
    
    drivers/tty/serial/8250/8250_of.c: In function 'of_platform_serial_probe':
    drivers/tty/serial/8250/8250_of.c:233:1: error: the frame size of 1200 bytes is larger than 1152 bytes [-Werror=frame-larger-than=]
    
    This is harmless by itself, but it shows two other problems in
    the driver:
    
    - It still tries to be generic enough to handle all kinds of serial
      ports, where in reality the driver has been 8250-only for a while,
      and every other uart has its own DT support
    
    - As a result of that generalization, we keep two copies of
      'struct uart_port' on the stack during probe(). This is completely
      unnessary.
    
    Removing the last code dealing with unsupported port_type values
    solves both problems nicely, and reduces the stack size.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    aa42db44
8250_of.c 7.92 KB