• Johan Hovold's avatar
    USB: serial: opticon: fix TIOCGSERIAL implementation · aa6a4585
    Johan Hovold authored
    TIOCSSERIAL is a horrid, underspecified, legacy interface which for most
    serial devices is only useful for setting the close_delay and
    closing_wait parameters.
    
    The xmit_fifo_size parameter could be used to set the hardware transmit
    fifo size of a legacy UART when it could not be detected, but the
    interface is limited to eight bits and should be left unset when not
    used.
    
    Similarly, baud_base could be used to set the UART base clock when it
    could not be detected but might as well be left unset when it is not
    known.
    
    The close_delay and closing_wait parameters returned by TIOCGSERIAL are
    specified in centiseconds (not jiffies). The driver does not yet support
    changing these, but let's report back the default values actually used
    (0.5 and 30 seconds, respectively).
    
    Fixes: faac64ad ("USB: serial: opticon: add serial line ioctls")
    Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
    aa6a4585
opticon.c 10.5 KB