• Chi Wu's avatar
    mm/page-writeback: Fix performance when BDI's share of ratio is 0. · ab19939a
    Chi Wu authored
    Fix performance when BDI's share of ratio is 0.
    
    The issue is similar to commit 74d36944 ("writeback: Fix
    performance regression in wb_over_bg_thresh()").
    
    Balance_dirty_pages and the writeback worker will also disagree on
    whether writeback when a BDI uses BDI_CAP_STRICTLIMIT and BDI's share
    of the thresh ratio is zero.
    
    For example, A thread on cpu0 writes 32 pages and then
    balance_dirty_pages, it will wake up background writeback and pauses
    because wb_dirty > wb->wb_thresh = 0 (share of thresh ratio is zero).
    A thread may runs on cpu0 again because scheduler prefers pre_cpu.
    Then writeback worker may runs on other cpus(1,2..) which causes the
    value of wb_stat(wb, WB_RECLAIMABLE) in wb_over_bg_thresh is 0 and does
    not writeback and returns.
    
    Thus, balance_dirty_pages keeps looping, sleeping and then waking up the
    worker who will do nothing. It remains stuck in this state until the
    writeback worker hit the right dirty cpu or the dirty pages expire.
    
    The fix that we should get the wb_stat_sum radically when thresh is low.
    
    Link: https://lkml.kernel.org/r/20210428225046.16301-1-wuchi.zero@gmail.comSigned-off-by: default avatarChi Wu <wuchi.zero@gmail.com>
    Reviewed-by: default avatarJan Kara <jack@suse.cz>
    Cc: Tejun Heo <tj@kernel.org>
    Cc: Miklos Szeredi <mszeredi@redhat.com>
    Cc: Sedat Dilek <sedat.dilek@gmail.com>
    Cc: Jens Axboe <axboe@fb.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    ab19939a
page-writeback.c 85 KB