• Jiri Slaby's avatar
    NET: cdc-phonet, fix stop-queue handling · ac90fa63
    Jiri Slaby authored
    Currently there is a warning emitted by the cdc-phonet driver:
    WARNING: at include/linux/netdevice.h:1557 usbpn_probe+0x3bb/0x3f0 [cdc_phonet]()
    Modules linked in: ...
    Pid: 5877, comm: insmod Not tainted 2.6.37.3-16-desktop #1
    Call Trace:
     [<ffffffff810059b9>] dump_trace+0x79/0x340
     [<ffffffff81520fdc>] dump_stack+0x69/0x6f
     [<ffffffff810580eb>] warn_slowpath_common+0x7b/0xc0
     [<ffffffffa00254fb>] usbpn_probe+0x3bb/0x3f0 [cdc_phonet]
    ...
    ---[ end trace f5d3e02908603ab4 ]---
    netif_stop_queue() cannot be called before register_netdev()
    
    So remove netif_stop_queue from the probe funtction to avoid that.
    Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
    Cc: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
    Cc: David S. Miller <davem@davemloft.net>
    Acked-by: default avatarRémi Denis-Courmont <remi.denis-courmont@nokia.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    ac90fa63
cdc-phonet.c 10.9 KB