• Yakov Lerner's avatar
    x86, kprobes: correct post-eip value in post_hander() · acb5b8a2
    Yakov Lerner authored
    I was trying to get the address of instruction to be executed
    next after the kprobed instruction.  But regs->eip in post_handler()
    contains value which is useless to the user. It's pre-corrected value.
    This value is difficult to use without access to resume_execution(), which
    is not exported anyway.
    I moved the invocation of post_handler() to *after* resume_execution().
    Now regs->eip contains meaningful value in post_handler().
    
    I do not think this change breaks any backward-compatibility.
    To make meaning of the old value, post_handler() would need access to
    resume_execution() which is not exported.  I have difficulty to believe
    that previous, uncorrected, regs->eip can be meaningfully used in
    post_handler().
    Signed-off-by: default avatarYakov Lerner <iler.ml@gmail.com>
    Acked-by: default avatarAnanth N Mavinakayanahalli <ananth@in.ibm.com>
    Acked-by: default avatarMasami Hiramatsu <mhiramat@redhat.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    acb5b8a2
kprobes.c 31.4 KB