• Kent Overstreet's avatar
    bcachefs: Don't require flush/fua on every journal write · adbcada4
    Kent Overstreet authored
    This patch adds a flag to journal entries which, if set, indicates that
    they weren't done as flush/fua writes.
    
     - non flush/fua journal writes don't update last_seq (i.e. they don't
       free up space in the journal), thus the journal free space
       calculations now check whether nonflush journal writes are currently
       allowed (i.e. are we low on free space, or would doing a flush write
       free up a lot of space in the journal)
    
     - write_delay_ms, the user configurable option for when open journal
       entries are automatically written, is now interpreted as the max
       delay between flush journal writes (default 1 second).
    
     - bch2_journal_flush_seq_async is changed to ensure a flush write >=
       the requested sequence number has happened
    
     - journal read/replay must now ignore, and blacklist, any journal
       entries newer than the most recent flush entry in the journal. Also,
       the way the read_entire_journal option is handled has been improved;
       struct journal_replay now has an entry, 'ignore', for entries that
       were read but should not be used.
    
     - assorted refactoring and improvements related to journal read in
       journal_io.c and recovery.c
    
    Previously, we'd have to issue a flush/fua write every time we
    accumulated a full journal entry - typically the bucket size. Now we
    need to issue them much less frequently: when an fsync is requested, or
    it's been more than write_delay_ms since the last flush, or when we need
    to free up space in the journal. This is a significant performance
    improvement on many write heavy workloads.
    Signed-off-by: default avatarKent Overstreet <kent.overstreet@gmail.com>
    Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
    adbcada4
journal_io.c 33.5 KB