• Ard Biesheuvel's avatar
    arm64/module: revert to unsigned interpretation of ABS16/32 relocations · 3fd00beb
    Ard Biesheuvel authored
    Commit 1cf24a2c
    
      ("arm64/module: deal with ambiguity in PRELxx relocation ranges")
    
    updated the overflow checking logic in the relocation handling code to
    ensure that PREL16/32 relocations don't overflow signed quantities.
    
    However, the same code path is used for absolute relocations, where the
    interpretation is the opposite: the only current use case for absolute
    relocations operating on non-native word size quantities is the CRC32
    handling in the CONFIG_MODVERSIONS code, and these CRCs are unsigned
    32-bit quantities, which are now being rejected by the module loader
    if bit 31 happens to be set.
    
    So let's use different ranges for quanties subject to absolute vs.
    relative relocations:
    - ABS16/32 relocations should be in the range [0, Uxx_MAX)
    - PREL16/32 relocations should be in the range [Sxx_MIN, Sxx_MAX)
    - otherwise, print an error since no other 16 or 32 bit wide data
      relocations are currently supported.
    Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
    Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
    3fd00beb
module.c 13.4 KB