• Dan Carpenter's avatar
    rndis_wlan: potential buffer overflow in rndis_wlan_auth_indication() · ae636fb1
    Dan Carpenter authored
    This is a static checker fix, not something I have tested.  The issue
    is that on the second iteration through the loop, we jump forward by
    le32_to_cpu(auth_req->length) bytes.  The problem is that if the length
    is more than "buflen" then we end up with a negative "buflen".  A
    negative buflen is type promoted to a high positive value and the loop
    continues but it's accessing beyond the end of the buffer.
    
    I believe the "auth_req->length" comes from the firmware and if the
    firmware is malicious or buggy, you're already toasted so the impact of
    this bug is probably not very severe.
    
    Fixes: 030645ac ("rndis_wlan: handle 802.11 indications from device")
    Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
    ae636fb1
rndis_wlan.c 100 KB