• Alexander Aring's avatar
    lockd: fix race in async lock request handling · afb13302
    Alexander Aring authored
    This patch fixes a race in async lock request handling between adding
    the relevant struct nlm_block to nlm_blocked list after the request was
    sent by vfs_lock_file() and nlmsvc_grant_deferred() does a lookup of the
    nlm_block in the nlm_blocked list. It could be that the async request is
    completed before the nlm_block was added to the list. This would end
    in a -ENOENT and a kernel log message of "lockd: grant for unknown
    block".
    
    To solve this issue we add the nlm_block before the vfs_lock_file() call
    to be sure it has been added when a possible nlmsvc_grant_deferred() is
    called. If the vfs_lock_file() results in an case when it wouldn't be
    added to nlm_blocked list, the nlm_block struct will be removed from
    this list again.
    Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
    Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
    Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
    afb13302
svclock.c 28.3 KB