• Dmitry Torokhov's avatar
    Input: ads7846 - check proper condition when freeing gpio · 0fbc9fdb
    Dmitry Torokhov authored
    When driver uses custom pendown detection method gpio_pendown is not
    set up and so we should not try to free it, otherwise we are presented
    with:
    
    ------------[ cut here ]------------
    WARNING: at drivers/gpio/gpiolib.c:1258 gpio_free+0x100/0x12c()
    Modules linked in:
    [<c0061208>] (unwind_backtrace+0x0/0xe4) from [<c0091f58>](warn_slowpath_common+0x4c/0x64)
    [<c0091f58>] (warn_slowpath_common+0x4c/0x64) from [<c0091f88>](warn_slowpath_null+0x18/0x1c)
    [<c0091f88>] (warn_slowpath_null+0x18/0x1c) from [<c024e610>](gpio_free+0x100/0x12c)
    [<c024e610>] (gpio_free+0x100/0x12c) from [<c03e9fbc>](ads7846_probe+0xa38/0xc5c)
    [<c03e9fbc>] (ads7846_probe+0xa38/0xc5c) from [<c02cff14>](spi_drv_probe+0x18/0x1c)
    [<c02cff14>] (spi_drv_probe+0x18/0x1c) from [<c028bca4>](driver_probe_device+0xc8/0x184)
    [<c028bca4>] (driver_probe_device+0xc8/0x184) from [<c028bdc8>](__driver_attach+0x68/0x8c)
    [<c028bdc8>] (__driver_attach+0x68/0x8c) from [<c028b4c8>](bus_for_each_dev+0x48/0x74)
    [<c028b4c8>] (bus_for_each_dev+0x48/0x74) from [<c028ae08>](bus_add_driver+0xa0/0x220)
    [<c028ae08>] (bus_add_driver+0xa0/0x220) from [<c028c0c0>](driver_register+0xa8/0x134)
    [<c028c0c0>] (driver_register+0xa8/0x134) from [<c0050550>](do_one_initcall+0xcc/0x1a4)
    [<c0050550>] (do_one_initcall+0xcc/0x1a4) from [<c00084e4>](kernel_init+0x14c/0x214)
    [<c00084e4>] (kernel_init+0x14c/0x214) from [<c005b494>](kernel_thread_exit+0x0/0x8)
    ---[ end trace 4053287f8a5ec18f ]---
    
    Also rearrange ads7846_setup_pendown() to have only one exit point
    returning success.
    Reported-by: default avatarSourav Poddar <sourav.poddar@ti.com>
    Acked-by: default avatarWolfram Sang <w.sang@pengutronix.de>
    Reviewed-by: default avatarCharulatha V <charu@ti.com>
    Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
    0fbc9fdb
ads7846.c 33.3 KB