• John David Anglin's avatar
    parisc: Disable debug code regarding cache flushes in handle_nadtlb_fault() · 67c35a3b
    John David Anglin authored
    Change the "BUG" to "WARNING" and disable the message because it triggers
    occasionally in spite of the check in flush_cache_page_if_present.
    
    The pte value extracted for the "from" page in copy_user_highpage is racy and
    occasionally the pte is cleared before the flush is complete.  I assume that
    the page is simultaneously flushed by flush_cache_mm before the pte is cleared
    as nullifying the fdc doesn't seem to cause problems.
    
    I investigated various locking scenarios but I wasn't able to find a way to
    sequence the flushes.  This code is called for every COW break and locks impact
    performance.
    
    This patch is related to the bigger cache flush patch because we need the pte
    on PA8800/PA8900 to flush using the vma context.
    I have also seen this from copy_to_user_page and copy_from_user_page.
    
    The messages appear infrequently when enabled.
    Signed-off-by: default avatarJohn David Anglin <dave.anglin@bell.net>
    Signed-off-by: default avatarHelge Deller <deller@gmx.de>
    67c35a3b
fault.c 13 KB