• Adrian Hunter's avatar
    perf intel-pt: Fix potential loop forever · 9992c2d5
    Adrian Hunter authored
    TSC packets contain only 7 bytes of TSC.  The 8th byte is assumed to
    change so infrequently that its value can be inferred.  However the
    logic must cater for a 7 byte wraparound, which it does by adding 1 to
    the top byte.
    
    The existing code was doing that with a while loop even though the
    addition should only need to be done once.  That logic won't work (will
    loop forever) if TSC wraps around at the 8th byte.  Theoretically that
    would take at least 10 years, unless something else went wrong.
    
    And what else could go wrong.  Well, if the chunks of trace data are
    processed out of order, it will make it look like the 7-byte TSC has
    gone backwards (i.e. wrapped).  If that happens 256 times then stuck in
    the while loop it will be.
    
    Fix that by getting rid of the unnecessary while loop.
    Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Link: http://lkml.kernel.org/r/1443186956-18718-4-git-send-email-adrian.hunter@intel.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    9992c2d5
intel-pt-decoder.c 55.9 KB