• Josh Poimboeuf's avatar
    x86/dumpstack: Fix interrupt and exception stack boundary checks · 5a3cf869
    Josh Poimboeuf authored
    On x86_64, the double fault exception stack is located immediately after
    the interrupt stack in memory.  This causes confusion in the unwinder
    when it tries to unwind through an empty interrupt stack, where the
    stack pointer points to the address bordering the two stacks.  The
    unwinder incorrectly thinks it's running on the double fault stack.
    
    Fix this kind of stack border confusion by never considering the
    beginning address of an exception or interrupt stack to be part of the
    stack.
    Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Jiri Slaby <jslaby@suse.cz>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: live-patching@vger.kernel.org
    Fixes: 5fe599e0 ("x86/dumpstack: Add support for unwinding empty IRQ stacks")
    Link: http://lkml.kernel.org/r/bcc142160a5104de5c354c21c394c93a0173943f.1499786555.git.jpoimboe@redhat.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    5a3cf869
dumpstack_32.c 3.61 KB