• alex chen's avatar
    ocfs2: should reclaim the inode if '__ocfs2_mknod_locked' returns an error · b1529a41
    alex chen authored
    In ocfs2_mknod_locked if '__ocfs2_mknod_locke		d' returns an error, we
    should reclaim the inode successfully claimed above, otherwise, the
    inode never be reused. The case is described below:
    
    ocfs2_mknod
        ocfs2_mknod_locked
            ocfs2_claim_new_inode
                    Successfully claim the inode
            __ocfs2_mknod_locked
                ocfs2_journal_access_di
                Failed because of -ENOMEM or other reasons, the inode
                            lockres has not been initialized yet.
    
        iput(inode)
            ocfs2_evict_inode
                ocfs2_delete_inode
                    ocfs2_inode_lock
                        ocfs2_inode_lock_full_nested
                            __ocfs2_cluster_lock
                                    Return -EINVAL because of the inode
                                    lockres has not been initialized.
    
                    So the following operations are not performed
                    ocfs2_wipe_inode
                            ocfs2_remove_inode
                                    ocfs2_free_dinode
                                            ocfs2_free_suballoc_bits
    Signed-off-by: default avatarAlex Chen <alex.chen@huawei.com>
    Reviewed-by: default avatarJoseph Qi <joseph.qi@huawei.com>
    Cc: Mark Fasheh <mfasheh@suse.de>
    Cc: Joel Becker <jlbec@evilplan.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    b1529a41
namei.c 70.5 KB