• David Howells's avatar
    KEYS: Fix error handling in construct_key_and_link() · b1d7dd80
    David Howells authored
    Fix error handling in construct_key_and_link().
    
    If construct_alloc_key() returns an error, it shouldn't pass out through
    the normal path as the key_serial() called by the kleave() statement
    will oops when it gets an error code in the pointer:
    
      BUG: unable to handle kernel paging request at ffffffffffffff84
      IP: [<ffffffff8120b401>] request_key_and_link+0x4d7/0x52f
      ..
      Call Trace:
       [<ffffffff8120b52c>] request_key+0x41/0x75
       [<ffffffffa00ed6e8>] cifs_get_spnego_key+0x206/0x226 [cifs]
       [<ffffffffa00eb0c9>] CIFS_SessSetup+0x511/0x1234 [cifs]
       [<ffffffffa00d9799>] cifs_setup_session+0x90/0x1ae [cifs]
       [<ffffffffa00d9c02>] cifs_get_smb_ses+0x34b/0x40f [cifs]
       [<ffffffffa00d9e05>] cifs_mount+0x13f/0x504 [cifs]
       [<ffffffffa00caabb>] cifs_do_mount+0xc4/0x672 [cifs]
       [<ffffffff8113ae8c>] mount_fs+0x69/0x155
       [<ffffffff8114ff0e>] vfs_kern_mount+0x63/0xa0
       [<ffffffff81150be2>] do_kern_mount+0x4d/0xdf
       [<ffffffff81152278>] do_mount+0x63c/0x69f
       [<ffffffff8115255c>] sys_mount+0x88/0xc2
       [<ffffffff814fbdc2>] system_call_fastpath+0x16/0x1b
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    Acked-by: default avatarJeff Layton <jlayton@redhat.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    b1d7dd80
request_key.c 19.3 KB