• Vladimir Oltean's avatar
    net: dsa: Call driver's setup callback after setting up its switchdev notifier · b2243b36
    Vladimir Oltean authored
    This allows the driver to perform some manipulations of its own during
    setup, using generic switchdev calls. Having the notifiers registered at
    setup time is important because otherwise any switchdev transaction
    emitted during this time would be ignored (dispatched to an empty call
    chain).
    
    One current usage scenario is for the driver to request DSA to set up
    802.1Q based switch tagging for its ports.
    
    There is no danger for the driver setup code to start racing now with
    switchdev events emitted from the network stack (such as bridge core)
    even if the notifier is registered earlier. This is because the network
    stack needs a net_device as a vehicle to perform switchdev operations,
    and the slave net_devices are registered later than the core driver
    setup anyway (ds->ops->setup in dsa_switch_setup vs dsa_port_setup).
    
    Luckily DSA doesn't need a net_device to carry out switchdev callbacks,
    and therefore drivers shouldn't assume either that net_devices are
    available at the time their switchdev callbacks get invoked.
    Signed-off-by: default avatarVladimir Oltean <olteanv@gmail.com>
    Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
    Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
    Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>-
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    b2243b36
dsa2.c 16.6 KB