• Sudeep Holla's avatar
    drivers: psci: annotate timer on stack to silence odebug messages · 4309cfe3
    Sudeep Holla authored
    When DEBUG_OBJECTS config is enabled, we get the below odebug warnings:
    
    ODEBUG: object is on stack, but not annotated
    
    WARNING: CPU: 3 PID: 1304 at kernel/lib/debugobjects.c:300 __debug_object_init+0x1f0/0x458
    CPU: 3 PID: 1304 Comm: psci_suspend_te Tainted: G W 4.9.0-06564-gf80f3f199260 #284
    task: ffffe9e1b55a1600 task.stack: ffffe9e1b51c0000
    PC is at __debug_object_init+0x1f0/0x458
    LR is at __debug_object_init+0x1ec/0x458
    Call trace:
     __debug_object_init+0x1f0/0x458
     debug_object_activate+0x150/0x260
     mod_timer+0xb4/0x4c0
     suspend_test_thread+0x1cc/0x3c0
     kthread+0x110/0x140
     ret_from_fork+0x10/0x40
    
    This patch annotates the timer on the stack using setup_timer_on_stack
    function to remove the above warnings.
    
    Cc: Kevin Brodsky <kevin.brodsky@arm.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
    Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    4309cfe3
psci_checker.c 12.6 KB