• Brian Norris's avatar
    mtd: nand: remove multiplied-by-2 block logic · b4d20d60
    Brian Norris authored
    The parent commit 771c568b ("mtd: nand: add
    accessors, macros for in-memory BBT") makes the following comment obsolete:
    
    	/*
    	 * Note that numblocks is 2 * (real numblocks) here, see i+=2
    	 * below as it makes shifting and masking less painful
    	 */
    
    I don't think it ever could have been "less painful" to have to shift an
    extra bit (or 2, or 3) at various points in nand_bbt.c (and even
    outside, since we leak our in-memory format). But now it is certainly
    more painful, since we have nice macros and functions to retrieve the
    relevant portions of the BBT.
    
    This patch removes any points where the block number is
    doubled/halved/otherwise-shifted, instead representing the block number
    in its most natural form: as the actual block number.
    Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
    Signed-off-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
    Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
    b4d20d60
nand_bbt.c 38.1 KB