• Breno Leitao's avatar
    elevator: do not request_module if elevator exists · b4ff6e93
    Breno Leitao authored
    Whenever an I/O elevator is changed, the system attempts to load a
    module for the new elevator. This occurs regardless of whether the
    elevator is already loaded or built directly into the kernel. This
    behavior introduces unnecessary overhead and potential issues.
    
    This makes the operation slower, and more error-prone. For instance,
    making the problem fixed by [1] visible for users that doesn't even rely
    on modules being available through modules.
    
    Do not try to load the ioscheduler if it is already visible.
    
    This change brings two main benefits: it improves the performance of
    elevator changes, and it reduces the likelihood of errors occurring
    during this process.
    
    [1] Commit e3accac1 ("block: Fix elv_iosched_local_module handling of "none" scheduler")
    
    Fixes: 734e1a86 ("block: Prevent deadlocks when switching elevators")
    Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
    Link: https://lore.kernel.org/r/20241011170122.3880087-1-leitao@debian.orgSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
    b4ff6e93
elevator.c 17.9 KB