• Remi Bernon's avatar
    perf symbol: Look for ImageBase in PE file to compute .text offset · d2930ede
    Remi Bernon authored
    Instead of using the file offset in the debug file.
    
    This fixes a regression from 00a34234 ("perf symbols: Make
    dso__load_bfd_symbols() load PE files from debug cache only"), causing
    incorrect symbol resolution when debug file have been stripped from
    non-debug sections (in which case its .text section is empty and doesn't
    have any file position).
    
    The debug files could also be created with a different file alignment,
    and have different file positions from the mmap-ed binary, or have the
    section reordered.
    
    This instead looks for the file image base, using the corresponding bfd
    *ABS* symbols. As PE symbols only have 4 bytes, it also needs to keep
    .text section vma high bits.
    Signed-off-by: default avatarRemi Bernon <rbernon@codeweavers.com>
    Fixes: 00a34234 ("perf symbols: Make dso__load_bfd_symbols() load PE files from debug cache only")
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Nicholas Fraser <nfraser@codeweavers.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lore.kernel.org/lkml/20210909192637.4139125-1-rbernon@codeweavers.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    d2930ede
symbol.c 59.1 KB