• Oleg Nesterov's avatar
    kthread: kill task_get_live_kthread() · b5c5442b
    Oleg Nesterov authored
    task_get_live_kthread() looks confusing and unneeded.  It does
    get_task_struct() but only kthread_stop() needs this, it can be called
    even if the calller doesn't have a reference when we know that this
    kthread can't exit until we do kthread_stop().
    
    kthread_park() and kthread_unpark() do not need get_task_struct(), the
    callers already have the reference.  And it can not help if we can race
    with the exiting kthread anyway, kthread_park() can hang forever in this
    case.
    
    Change kthread_park() and kthread_unpark() to use to_live_kthread(),
    change kthread_stop() to do get_task_struct() by hand and remove
    task_get_live_kthread().
    Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Rusty Russell <rusty@rustcorp.com.au>
    Cc: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
    Cc: Tejun Heo <tj@kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    b5c5442b
kthread.c 17 KB