• Brett Creeley's avatar
    ice: Print the api_patch as part of the fw.mgmt.api · b726ddf9
    Brett Creeley authored
    Currently when a user uses "devlink dev info", the fw.mgmt.api will be
    the major.minor numbers as shown below:
    
    devlink dev info pci/0000:3b:00.0
    pci/0000:3b:00.0:
      driver ice
      serial_number 00-01-00-ff-ff-00-00-00
      versions:
          fixed:
            board.id K91258-000
          running:
            fw.mgmt 6.1.2
            fw.mgmt.api 1.7 <--- No patch number included
            fw.mgmt.build 0xd75e7d06
            fw.mgmt.srev 5
            fw.undi 1.2992.0
            fw.undi.srev 5
            fw.psid.api 3.10
            fw.bundle_id 0x800085cc
            fw.app.name ICE OS Default Package
            fw.app 1.3.27.0
            fw.app.bundle_id 0xc0000001
            fw.netlist 3.10.2000-3.1e.0
            fw.netlist.build 0x2a76e110
          stored:
            fw.mgmt.srev 5
            fw.undi 1.2992.0
            fw.undi.srev 5
            fw.psid.api 3.10
            fw.bundle_id 0x800085cc
            fw.netlist 3.10.2000-3.1e.0
            fw.netlist.build 0x2a76e110
    
    There are many features in the driver that depend on the major, minor,
    and patch version of the FW. Without the patch number in the output for
    fw.mgmt.api debugging issues related to the FW API version is difficult.
    Also, using major.minor.patch aligns with the existing firmware version
    which uses a 3 digit value.
    
    Fix this by making the fw.mgmt.api print the major.minor.patch
    versions. Shown below is the result:
    
    devlink dev info pci/0000:3b:00.0
    pci/0000:3b:00.0:
      driver ice
      serial_number 00-01-00-ff-ff-00-00-00
      versions:
          fixed:
            board.id K91258-000
          running:
            fw.mgmt 6.1.2
            fw.mgmt.api 1.7.9 <--- patch number included
            fw.mgmt.build 0xd75e7d06
            fw.mgmt.srev 5
            fw.undi 1.2992.0
            fw.undi.srev 5
            fw.psid.api 3.10
            fw.bundle_id 0x800085cc
            fw.app.name ICE OS Default Package
            fw.app 1.3.27.0
            fw.app.bundle_id 0xc0000001
            fw.netlist 3.10.2000-3.1e.0
            fw.netlist.build 0x2a76e110
          stored:
            fw.mgmt.srev 5
            fw.undi 1.2992.0
            fw.undi.srev 5
            fw.psid.api 3.10
            fw.bundle_id 0x800085cc
            fw.netlist 3.10.2000-3.1e.0
            fw.netlist.build 0x2a76e110
    
    Fixes: ff2e5c70 ("ice: add basic handler for devlink .info_get")
    Signed-off-by: default avatarBrett Creeley <brett.creeley@intel.com>
    Tested-by: default avatarGurucharan G <gurucharanx.g@intel.com>
    Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
    b726ddf9
ice_devlink.c 21.3 KB