• Yang Shi's avatar
    mm/memory.c: skip spurious TLB flush for retried page fault · b7333b58
    Yang Shi authored
    Recently we found regression when running will_it_scale/page_fault3 test
    on ARM64.  Over 70% down for the multi processes cases and over 20% down
    for the multi threads cases.  It turns out the regression is caused by
    commit 89b15332 ("mm: drop mmap_sem before calling
    balance_dirty_pages() in write fault").
    
    The test mmaps a memory size file then write to the mapping, this would
    make all memory dirty and trigger dirty pages throttle, that upstream
    commit would release mmap_sem then retry the page fault.  The retried
    page fault would see correct PTEs installed then just fall through to
    spurious TLB flush.  The regression is caused by the excessive spurious
    TLB flush.  It is fine on x86 since x86's spurious TLB flush is no-op.
    
    We could just skip the spurious TLB flush to mitigate the regression.
    Suggested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    Reported-by: default avatarXu Yu <xuyu@linux.alibaba.com>
    Debugged-by: default avatarXu Yu <xuyu@linux.alibaba.com>
    Tested-by: default avatarXu Yu <xuyu@linux.alibaba.com>
    Cc: Johannes Weiner <hannes@cmpxchg.org>
    Cc: Catalin Marinas <catalin.marinas@arm.com>
    Cc: Will Deacon <will.deacon@arm.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarYang Shi <shy828301@gmail.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    b7333b58
memory.c 137 KB