• Thomas Gleixner's avatar
    arm: Remove bogus comment in futex_atomic_cmpxchg_inatomic() · 07d5ecae
    Thomas Gleixner authored
    commit 522d7dec(futex: Remove redundant pagefault_disable in
    futex_atomic_cmpxchg_inatomic()) added a bogus comment.
    
    /* Note that preemption is disabled by futex_atomic_cmpxchg_inatomic
     * call sites. */
    
    Bogus in two aspects:
    
    1) pagefault_disable != preempt_disable even if the mechanism we use
       is the same
    
    2) we have a call site which deliberately does not disable pagefaults
       as it wants the possible fault to be handled - though that has been
       changed for consistency reasons now.
    
    Sigh. I really should have seen that when committing the above. :(
    Catched-by-and-rightfully-ranted-at-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    LKML-Reference: <alpine.LFD.2.00.1103141126590.2787@localhost6.localdomain6>
    Cc: Michel Lespinasse <walken@google.com>
    Cc: Darren Hart <darren@dvhart.com>
    07d5ecae
futex.h 3.01 KB