• Christian Brauner's avatar
    ksmbd: use vfs_remove_acl() · b82784a2
    Christian Brauner authored
    The current way of setting and getting posix acls through the generic
    xattr interface is error prone and type unsafe. The vfs needs to
    interpret and fixup posix acls before storing or reporting it to
    userspace. Various hacks exist to make this work. The code is hard to
    understand and difficult to maintain in it's current form. Instead of
    making this work by hacking posix acls through xattr handlers we are
    building a dedicated posix acl api around the get and set inode
    operations. This removes a lot of hackiness and makes the codepaths
    easier to maintain. A lot of background can be found in [1].
    
    Now that we've switched all filesystems that can serve as the lower
    filesystem for ksmbd we can switch ksmbd over to rely on
    the posix acl api. Note that this is orthogonal to switching the vfs
    itself over.
    
    Link: https://lore.kernel.org/all/20220801145520.1532837-1-brauner@kernel.org [1]
    Signed-off-by: default avatarChristian Brauner (Microsoft) <brauner@kernel.org>
    b82784a2
vfs.c 44.7 KB