• Lai Jiangshan's avatar
    ring_buffer: fix typing mistake · b85fa01e
    Lai Jiangshan authored
    Impact: Fix bug
    
    I found several very very curious line.
    It's so curious that it may be brought by typing mistake.
    
    When (cpu_buffer->reader_page == cpu_buffer->commit_page):
    
    1) We haven't copied it for bpage is changed:
       bpage = cpu_buffer->reader_page->page;
       memcpy(bpage->data, cpu_buffer->reader_page->page->data + read ... )
    2) We need update cpu_buffer->reader_page->read, but
       "cpu_buffer->reader_page += read;" is not right.
    
    [
      This bug was a typo. The commit->reader_page is a page pointer
      and not an index into the page. The line should have been
      commit->reader_page->read += read.  The other changes
      by Lai are nice clean ups to the code.  - SDR
    ]
    Signed-off-by: default avatarLai Jiangshan <laijs@cn.fujitsu.com>
    Signed-off-by: default avatarSteven Rostedt <srostedt@redhat.com>
    b85fa01e
ring_buffer.c 62.8 KB