• Mark Brown's avatar
    Merge series "Tidy up device ID reading on legacy Cirrus parts" from Charles... · b8ded8af
    Mark Brown authored
    Merge series "Tidy up device ID reading on legacy Cirrus parts" from Charles Keepax <ckeepax@opensource.cirrus.com>:
    
    Pierre requested I have a look at some cppcheck warnings in the cs42l42
    driver, since it is reassigning the ret variable without ever checking
    the result.  Looking a bit more broadly this happens in quite a few
    legacy Cirrus parts, as they all use the same process to read the ID,
    factor out a small helper so they can all share the same code. Whilst
    in there fix up a couple of other trivial error path issues as well.
    
    Thanks,
    Charles
    
    Charles Keepax (10):
      ASoC: cirrus: Add helper function for reading the device ID
      ASoC: cs35l32: Minor error paths fixups
      ASoC: cs35l33: Minor error paths fixups
      ASoC: cs35l34:  Minor error paths fixups
      ASoC: cs35l35:  Minor error paths fixups
      ASoC: cs35l35: Correct errata handling
      ASoC: cs42l42:  Minor error paths fixups
      ASoC: cs42l73:  Minor error paths fixups
      ASoC: cs43130:  Minor error paths fixups
      ASoC: cs53l30:  Minor error paths fixups
    
     sound/soc/codecs/cirrus_legacy.h | 21 +++++++++++++++++++++
     sound/soc/codecs/cs35l32.c       | 34 ++++++++++++++++++----------------
     sound/soc/codecs/cs35l33.c       | 15 +++++++++------
     sound/soc/codecs/cs35l34.c       | 39 ++++++++++++++++++++++-----------------
     sound/soc/codecs/cs35l35.c       | 21 ++++++++++-----------
     sound/soc/codecs/cs35l35.h       |  1 +
     sound/soc/codecs/cs42l42.c       | 18 ++++++++----------
     sound/soc/codecs/cs42l73.c       | 30 +++++++++++++++++-------------
     sound/soc/codecs/cs43130.c       | 31 +++++++++++++++++++------------
     sound/soc/codecs/cs53l30.c       | 22 +++++++++++-----------
     10 files changed, 136 insertions(+), 96 deletions(-)
     create mode 100644 sound/soc/codecs/cirrus_legacy.h
    
    --
    2.11.0
    b8ded8af
cs42l42.c 60.5 KB