• Karl Beldan's avatar
    mac80211: minstrel_ht: use group flags instead of index to display rates · 8ec7886b
    Karl Beldan authored
    When displaying a rate through debugfs minstrel_ht guesses its flags
    comparing group indexes.  Since 3ec373c4 ("mac80211: minstrel_ht:
    include type (cck/ht) in rates flag"), the rate flags of interest are
    present in the mcs_group-s, so use it.
    While improving the code, this also fixes a smatch false positive
    "error: testing array offset 'i' after use" in minstrel_ht_stats_dump.
    This warning only triggers after 9208247d ("mac80211: minstrel_ht:
    add basic support for VHT rates <= 3SS@80MHz") with
    CONFIG_MAC80211_RC_MINSTREL_VHT unset because then MINSTREL_VHT_GROUP_0
    is above MINSTREL_GROUPS_NB and smatch only barks when the "testing
    array offset" seems to prevent possible out of bonds accesses (which
    does not happen here since i < ARRAY_SIZE(mi->groups)).
    Signed-off-by: default avatarKarl Beldan <karl.beldan@rivierawaves.com>
    Cc: Felix Fietkau <nbd@openwrt.org>
    Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
    8ec7886b
rc80211_minstrel_ht_debugfs.c 4.19 KB