• Zhen Lei's avatar
    rcu: Delete a redundant check in rcu_check_gp_kthread_starvation() · b934b7ff
    Zhen Lei authored
    The rcu_check_gp_kthread_starvation() function uses task_cpu() to sample
    the last CPU that the grace-period kthread ran on, and task_cpu() samples
    the thread_info structure's ->cpu field.  But this field will always
    contain a number corresponding to a CPU that was online some time in
    the past, thus never a negative number.  This invariant is checked by
    a WARN_ON_ONCE() in set_task_cpu().
    
    This means that if the grace-period kthread exists, that is, if the "gpk"
    local variable is non-NULL, the "cpu" local variable will be non-negative.
    This in turn means that the existing check for non-negative "cpu" is
    redundant with the enclosing check for non-NULL "gpk".
    
    This commit threefore removes the redundant check of "cpu".
    Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
    Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
    Signed-off-by: default avatarFrederic Weisbecker <frederic@kernel.org>
    b934b7ff
tree_stall.h 32.1 KB