• Mikulas Patocka's avatar
    alpha: fix broken network checksum · b93b90ff
    Mikulas Patocka authored
    commit 0ef38d70 upstream.
    
    The patch 3ddc5b46 breaks networking on
    alpha (there is a follow-up fix 5cfe8f1b,
    but networking is still broken even with the second patch).
    
    The patch 3ddc5b46 makes
    csum_partial_copy_from_user check the pointer with access_ok. However,
    csum_partial_copy_from_user is called also from csum_partial_copy_nocheck
    and csum_partial_copy_nocheck is called on kernel pointers and it is
    supposed not to check pointer validity.
    
    This bug results in ssh session hangs if the system is loaded and bulk
    data are printed to ssh terminal.
    
    This patch fixes csum_partial_copy_nocheck to call set_fs(KERNEL_DS), so
    that access_ok in csum_partial_copy_from_user accepts kernel-space
    addresses.
    Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
    Signed-off-by: default avatarMatt Turner <mattst88@gmail.com>
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    b93b90ff
csum_partial_copy.c 8.81 KB