• Kent Overstreet's avatar
    bcachefs: Eytzinger accumulation for accounting keys · b9efa967
    Kent Overstreet authored
    The btree write buffer takes as input keys from the journal, sorts them,
    deduplicates them, and flushes them back to the btree in sorted order.
    
    The disk space accounting rewrite is moving accounting to normal btree
    keys, with update (in this case deltas) accumulated in the write buffer
    and then flushed to the btree; but this is going to increase the number
    of keys handled by the write buffer by perhaps as much as a factor of
    3x-5x.
    
    The overhead from copying around and sorting this many keys would cause
    a significant performance regression, but: there is huge locality in
    updates to accounting keys that we can take advantage of.
    
    Instead of appending accounting keys to the list of keys to be sorted,
    this patch adds an eytzinger search tree of recently seen accounting
    keys. We look up the accounting key in the eytzinger search tree and
    apply the delta directly, adding it if it doesn't exist, and
    periodically prune the eytzinger tree of unused entries.
    Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
    b9efa967
journal_io.c 54.4 KB